Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver/docker: ignore error if container exists before cgroup can be written #10416

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

nickethier
Copy link
Member

This PR fixes an edge case in the reserved cores feature where switching the cpuset of a docker container occurs after the container has exited.

@nickethier nickethier assigned shoenig and unassigned shoenig Apr 21, 2021
@nickethier nickethier requested a review from shoenig April 21, 2021 02:07
return cgroups.WriteCgroupProc(path, pid)
// Sometimes the container exists before we can write the
// cgroup resulting in an error which can be ignored.
if err := cgroups.WriteCgroupProc(path, pid); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall the semantics of children processes and WriteCgroupProc. Is there a risk that we may miss some children processes here? Like if PID 1 is a entrypoint script and launches the main process without using exec, the main process may not be included in the cpusets?

@notnoop notnoop merged commit 646e811 into main Jun 9, 2021
@notnoop notnoop deleted the b-cores-docker branch June 9, 2021 14:34
@notnoop notnoop added this to the 1.1.1 milestone Jun 9, 2021
@notnoop notnoop mentioned this pull request Jun 9, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants